feat: support import.meta.hot hmr alias#14555
Conversation
Deploying rspack with
|
| Latest commit: |
c3946ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89f641ad.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-import-meta-hot-alias.rspack-v2.pages.dev |
📦 Binary Size-limit
🙈 Size remains the same at 66.55MB |
Merging this PR will not alter performance
Comparing 
Footnotes
|
intellild
force-pushed
the
codex/import-meta-hot-alias
branch
from
d09afb5 to
37c1019
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37c1019ba8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
intellild
force-pushed
the
codex/import-meta-hot-alias
branch
from
37c1019 to
af929dc
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📁 react-10kPath:
📁 react-1kPath:
📁 react-5kPath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
intellild
force-pushed
the
codex/import-meta-hot-alias
branch
from
af929dc to
f0c76d0
Compare
intellild
force-pushed
the
codex/import-meta-hot-alias
branch
from
f0c76d0 to
21ed178
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 766aeee37d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 766aeee37d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 267b01d2b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
import.meta.hotas an alias ofimport.meta.webpackHotin the HMR parser.ImportMeta.hottyping and document the alias in the HMR runtime API docs.Motivation
Bun, Deno, and Vite already support
import.meta.hotfor HMR. Adding the same entry in Rspack keeps the HMR interface consistent across modern runtimes while preserving the existingimport.meta.webpackHotAPI.Validation
pnpm --filter @rspack/core buildpnpm run build:binding:devcorepack pnpm --filter @rspack/tests test -t "configCases/issues/issue-14974"corepack pnpm --filter @rspack/tests test -t "configCases/parsing/import-meta-hot"corepack pnpm --filter @rspack/tests test -t "configCases/parsing/import-meta-hot-prod"by OpenAI Codex